feat: add supported_scopes method and scope: :all shorthand#109
Merged
feat: add supported_scopes method and scope: :all shorthand#109
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #107
Adds a public API for discovering and using all scopes supported by the OAuth authorization server, eliminating the need to call private methods.
Changes
OAuthProvidersupported_scopesmethod — returnsArray<String>of scopes from server discovery, or[]if the server does not advertise scopes. Result is memoized.scope: :allshorthand — when scope is set to the symbol:all, it is resolved lazily duringstart_authorization_flowtosupported_scopes.join(" ")without mutating@scope.Before / After
Before:
After:
Tests
supported_scopesreturns array from server metadatasupported_scopesreturns[]whenscopes_supportedis nilscope: :allresolves correctly during authorization flowBranch: feature/supported-scopes
URL: https://github.com/simonx1/ruby-mcp-client/pull/new/feature/supported-scopes